Change in openvpn[master]: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
A message that is not in the archive (sent off-list or not yet received): gerrit.1754309687000.I9159e2e354170ad6dbed5a6ce620f57fa8ab128e@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email
to review the following change.
Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
......................................................................
GHA: enable -Werror for mbedTLS v3 and AWS LC builds
Because we can and so we should.
---
M .github/workflows/build.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1128/1
.github/workflows/build.yaml +2 -2
@@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=mbedtls + run: ./configure --with-crypto-library=mbedtls --enable-werror - name: make all run: make -j3 - name: configure checks
@@ -489,7 +489,7 @@ OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=openssl + ./configure --with-crypto-library=openssl --enable-werror - name: make all run: make -j3 - name: configure checks
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, plaisthos.
uddr has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email )
Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 04 Aug 2025 12:34:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 GHA: enable -Werror for mbedTLS v3 and AWS LC builds
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Because we can and so we should.
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1128
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Yuriy Darnobyt <[email protected]...>
.github/workflows/build.yaml +2 -2
@@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=mbedtls + run: ./configure --with-crypto-library=mbedtls --enable-werror - name: make all run: make -j3 - name: configure checks
@@ -489,7 +489,7 @@ OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=openssl + ./configure --with-crypto-library=openssl --enable-werror - name: make all run: make -j3 - name: configure checks
[Openvpn-devel] [PATCH applied] Re: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
Indeed!
Your patch has been applied to the master branch.
commit c667671653fbe0b781cab6eee3e7c90783ffd132
Author: Frank Lichtenheld Date: Mon Aug 4 15:34:07 2025 +0200
GHA: enable -Werror for mbedTLS v3 and AWS LC builds
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Yuriy Darnobyt <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32505.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by uddr
Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
......................................................................
GHA: enable -Werror for mbedTLS v3 and AWS LC builds
Because we can and so we should.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32505.html
---
M .github/workflows/build.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1128/2
.github/workflows/build.yaml +2 -2
@@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=mbedtls + run: ./configure --with-crypto-library=mbedtls --enable-werror - name: make all run: make -j3 - name: configure checks
@@ -489,7 +489,7 @@ OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=openssl + ./configure --with-crypto-library=openssl --enable-werror - name: make all run: make -j3 - name: configure checks
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email )
Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds
......................................................................
GHA: enable -Werror for mbedTLS v3 and AWS LC builds
Because we can and so we should.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32505.html
---
M .github/workflows/build.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +2 -2
@@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=mbedtls + run: ./configure --with-crypto-library=mbedtls --enable-werror - name: make all run: make -j3 - name: configure checks
@@ -489,7 +489,7 @@ OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=openssl + ./configure --with-crypto-library=openssl --enable-werror - name: make all run: make -j3 - name: configure checks
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged